From 026f577e37d6630db11c948dfba9bfcf22017d73 Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Fri, 3 Jun 2022 20:32:16 -0400 Subject: [PATCH] feat: drop EOL Node 17 --- .github/workflows/alpine.yml | 3 +-- .github/workflows/linux.yml | 5 ----- .github/workflows/macos.yml | 1 - .github/workflows/windows.yml | 3 --- README.md | 2 +- appveyor.yml | 3 --- 6 files changed, 2 insertions(+), 15 deletions(-) diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml index 83d74aaef..5c2c9065b 100644 --- a/.github/workflows/alpine.yml +++ b/.github/workflows/alpine.yml @@ -16,9 +16,8 @@ jobs: matrix: node: - 14 - # Node 16 and 17 are perma-red for the tests right now + # Node 16 and 18 are perma-red for the tests right now # - 16 - # - 17 # - 18 steps: diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index e91076edd..e4f8457f6 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -16,7 +16,6 @@ jobs: node: - 14 - 16 - - 17 - 18 include: @@ -28,10 +27,6 @@ jobs: gcc: "gcc-8" gpp: "g++-8" os: ubuntu-18.04 - - node: 17 - gcc: "gcc-8" - gpp: "g++-8" - os: ubuntu-18.04 - node: 18 gcc: "gcc-8" gpp: "g++-8" diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index e3cdf64be..49e041351 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -16,7 +16,6 @@ jobs: node: - 14 - 16 - - 17 - 18 steps: diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 6f507f1a8..97f796fec 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -16,7 +16,6 @@ jobs: node: - 14 - 16 - - 17 - 18 architecture: @@ -28,8 +27,6 @@ jobs: os: windows-2019 - node: 16 os: windows-2019 - - node: 17 - os: windows-2019 - node: 18 os: windows-2019 diff --git a/README.md b/README.md index f3c7ea4df..6b446c3da 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,7 @@ Below is a quick guide for minimum and maximum supported versions of node-sass: NodeJS | Supported node-sass version | Node Module --------|-----------------------------|------------ Node 18 | 8.0+ | 108 -Node 17 | 7.0+ | 102 +Node 17 | 7.0+, <8.0 | 102 Node 16 | 6.0+ | 93 Node 15 | 5.0+, <7.0 | 88 Node 14 | 4.14+ | 83 diff --git a/appveyor.yml b/appveyor.yml index 162ea62ed..80bace49f 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -39,9 +39,6 @@ - nodejs_version: 16 GYP_MSVS_VERSION: 2019 APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 - - nodejs_version: 17 - GYP_MSVS_VERSION: 2019 - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 - nodejs_version: 18 GYP_MSVS_VERSION: 2019 APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019