From 2c6b8756cf7f4886b31b5fded47c7cba7f6acb50 Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Sat, 22 Oct 2022 23:33:08 -0400 Subject: [PATCH] feat: Node 19 support --- .github/workflows/alpine.yml | 3 ++- .github/workflows/linux.yml | 4 ++++ .github/workflows/macos.yml | 1 + .github/workflows/windows.yml | 11 ++--------- README.md | 1 + appveyor.yml | 3 +++ lib/extensions.js | 1 + 7 files changed, 14 insertions(+), 10 deletions(-) diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml index 5c2c9065b..c918e3e69 100644 --- a/.github/workflows/alpine.yml +++ b/.github/workflows/alpine.yml @@ -16,9 +16,10 @@ jobs: matrix: node: - 14 - # Node 16 and 18 are perma-red for the tests right now + # Node 16+ are perma-red for the tests right now # - 16 # - 18 + # - 19 steps: - name: Install Alpine build tools diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index e4f8457f6..4d41f6567 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -31,6 +31,10 @@ jobs: gcc: "gcc-8" gpp: "g++-8" os: ubuntu-20.04 + - node: 19 + gcc: "gcc-8" + gpp: "g++-8" + os: ubuntu-20.04 steps: diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 49e041351..e03df1faa 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -17,6 +17,7 @@ jobs: - 14 - 16 - 18 + - 19 steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 97f796fec..0ee040ef0 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -8,7 +8,7 @@ on: jobs: build: - runs-on: ${{ matrix.os }} + runs-on: windows-2019 strategy: fail-fast: false @@ -17,19 +17,12 @@ jobs: - 14 - 16 - 18 + - 19 architecture: - x64 - x86 - include: - - node: 14 - os: windows-2019 - - node: 16 - os: windows-2019 - - node: 18 - os: windows-2019 - steps: - uses: actions/checkout@v3 diff --git a/README.md b/README.md index 6b446c3da..f08caf777 100644 --- a/README.md +++ b/README.md @@ -17,6 +17,7 @@ Below is a quick guide for minimum and maximum supported versions of node-sass: NodeJS | Supported node-sass version | Node Module --------|-----------------------------|------------ +Node 19 | 8.0+ | 111 Node 18 | 8.0+ | 108 Node 17 | 7.0+, <8.0 | 102 Node 16 | 6.0+ | 93 diff --git a/appveyor.yml b/appveyor.yml index 80bace49f..4a6837ddd 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -42,6 +42,9 @@ - nodejs_version: 18 GYP_MSVS_VERSION: 2019 APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 + - nodejs_version: 19 + GYP_MSVS_VERSION: 2019 + APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 install: diff --git a/lib/extensions.js b/lib/extensions.js index 24b212e9b..4622f5dc5 100644 --- a/lib/extensions.js +++ b/lib/extensions.js @@ -83,6 +83,7 @@ function getHumanNodeVersion(abi) { case 93: return 'Node.js 16.x'; case 102: return 'Node.js 17.x'; case 108: return 'Node.js 18.x'; + case 111: return 'Node.js 19.x'; default: return false; } }