Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
I've always had some doubts about this variable but during the v3.5.0 release process (#1451) it became obvious to me: why have a separate variable only to stop the download, if another (
So, we have those effects:
SKIP_SASS_BINARY_DOWNLOAD_FOR_CI=1 and SASS_FORCE_BUILD=0 : no download, the build will be started due to empty
SKIP_SASS_BINARY_DOWNLOAD_FOR_CI=0 and SASS_FORCE_BUILD=1: download occurs, but the build proceeds anyway, overwriting the downloaded file (if successful).
Maybe we should use only SASS_FORCE_BUILD and drop the unofficial SKIP_SASS_BINARY_DOWNLOAD_FOR_CI ?
There's an interesting use case for
I'd be curious to see if this has any side effects. I predict slightly slower builds which isn't a bug deal.