This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Reconsider the process.env.SKIP_SASS_BINARY_DOWNLOAD_FOR_CI #1453
Comments
|
There's an interesting use case for
I'd be curious to see if this has any side effects. I predict slightly slower builds which isn't a bug deal. |
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this issue
Sep 26, 2016
This flag means we skip a bunch of code paths in CI which is not ideal. Since we tell people to use `npm rebuild` we should eat our own dog food. With this patch we do an install, then do a rebuild hitting all the major install code paths. Fixes sass#1453
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this issue
Sep 26, 2016
This flag means we skip a bunch of code paths in CI which is not ideal. Since we tell people to use `npm rebuild` we should eat our own dog food. With this patch we do an install, then do a rebuild hitting all the major install code paths. Fixes sass#1453
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this issue
Nov 8, 2016
This flag means we skip a bunch of code paths in CI which is not ideal. Since we tell people to use `npm rebuild` we should eat our own dog food. With this patch we do an install, then do a rebuild hitting all the major install code paths. Fixes sass#1453
xzyfer
added a commit
that referenced
this issue
Nov 7, 2019
This flag means we skip a bunch of code paths in CI which is not ideal. Since we tell people to use `npm rebuild` we should eat our own dog food. With this patch we do an install, then do a rebuild hitting all the major install code paths. Fixes #1453
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this issue
Nov 7, 2019
This flag means we skip a bunch of code paths in CI which is not ideal. Since we tell people to use `npm rebuild` we should eat our own dog food. With this patch we do an install, then do a rebuild hitting all the major install code paths. Fixes sass#1453
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this issue
Nov 7, 2019
This flag means we skip a bunch of code paths in CI which is not ideal. Since we tell people to use `npm rebuild` we should eat our own dog food. With this patch we do an install, then do a rebuild hitting all the major install code paths. Fixes sass#1453
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this issue
Nov 7, 2019
This flag means we skip a bunch of code paths in CI which is not ideal. Since we tell people to use `npm rebuild` we should eat our own dog food. With this patch we do an install, then do a rebuild hitting all the major install code paths. Fixes sass#1453
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this issue
Nov 7, 2019
This flag means we skip a bunch of code paths in CI which is not ideal. Since we tell people to use `npm rebuild` we should eat our own dog food. With this patch we do an install, then do a rebuild hitting all the major install code paths. Fixes sass#1453
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this issue
Nov 7, 2019
This flag means we skip a bunch of code paths in CI which is not ideal. Since we tell people to use `npm rebuild` we should eat our own dog food. With this patch we do an install, then do a rebuild hitting all the major install code paths. Fixes sass#1453
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this issue
Nov 7, 2019
This flag means we skip a bunch of code paths in CI which is not ideal. Since we tell people to use `npm rebuild` we should eat our own dog food. With this patch we do an install, then do a rebuild hitting all the major install code paths. Fixes sass#1453
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this issue
Nov 7, 2019
This flag means we skip a bunch of code paths in CI which is not ideal. Since we tell people to use `npm rebuild` we should eat our own dog food. With this patch we do an install, then do a rebuild hitting all the major install code paths. Fixes sass#1453
xzyfer
added a commit
that referenced
this issue
Nov 8, 2019
This flag means we skip a bunch of code paths in CI which is not ideal. Since we tell people to use `npm rebuild` we should eat our own dog food. With this patch we do an install, then do a rebuild hitting all the major install code paths. Fixes #1453
|
Closed by #1734 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I've always had some doubts about this variable but during the v3.5.0 release process (#1451) it became obvious to me: why have a separate variable only to stop the download, if another (
SASS_FORCE_BUILDor-fflag) is used to force the build anyway?So, we have those effects:
SKIP_SASS_BINARY_DOWNLOAD_FOR_CI=1 and SASS_FORCE_BUILD=0 : no download, the build will be started due to empty
vendordirectory if the binary hasn't been planted there otherwise (manual install)SKIP_SASS_BINARY_DOWNLOAD_FOR_CI=0 and SASS_FORCE_BUILD=1: download occurs, but the build proceeds anyway, overwriting the downloaded file (if successful).
Maybe we should use only SASS_FORCE_BUILD and drop the unofficial SKIP_SASS_BINARY_DOWNLOAD_FOR_CI ?
The text was updated successfully, but these errors were encountered: