Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution support for linux s390x? #2658

Open
viane opened this issue May 1, 2019 · 9 comments
Open

Distribution support for linux s390x? #2658

viane opened this issue May 1, 2019 · 9 comments

Comments

@viane
Copy link

viane commented May 1, 2019

Hi, is it possible to contribute s390x binaries to the official repo without providing a s390x env? I have built v4.11.0 by using node v8-v11 under a real s390x node but unfortunately there is no way for me to get a node for public testing...

linux-s390x-57_binding.node.zip
linux-s390x-59_binding.node.zip
linux-s390x-64_binding.node.zip
linux-s390x-67_binding.node.zip

And if no download available, it would take 3 minutes each time to build the fresh node-sass for our CI pipeline.

@nschonni
Copy link
Contributor

Unless we can get a CI to consistently produce the binaries as part of our release process, we can't support the platform. This is similar to the requests for ARM support (which may change if the CI testing for that works out)

@saper
Copy link
Member

saper commented Oct 17, 2019

@viane could this work under Hercules or something?

@viane
Copy link
Author

viane commented Oct 17, 2019

@saper I read couple things about Hercules simulator running zlinux, and it sounds very achievable, i will play around the simulator and get back to you guys. Big thanks for brought this up!

@saper
Copy link
Member

saper commented Oct 17, 2019

While here we don't we get node-sass working on MVS :)

@viane
Copy link
Author

viane commented Oct 17, 2019

I think it will come with a price... and z/OS native support for nodejs is only up to v6, which is not a good option here I think. Which make me still want to try linux on z on the simulator first.

@nschonni
Copy link
Contributor

Looks like Travis has added support now https://blog.travis-ci.com/2019-11-12-multi-cpu-architecture-ibm-power-ibm-z

@viane
Copy link
Author

viane commented Nov 14, 2019

I tested build with travis, they seems like having issue with s390x arch builds. Will come back on this once they resolve the issue.

Also in few failed s390x builds, they are 2 common failing testcases:

  6084 passing (35s)
  753 pending
  2 failing
  1) binding missing error should be useful:
     Error: Node Sass does not yet support your current environment: Unsupported platform (unknown) 64-bit with Node.js 6.x
For more information on which environments are supported please see:
https://github.com/sass/node-sass/releases/tag/v4.13.0
      at module.exports (lib/binding.js:13:13)
      at test/binding.js:16:22
      at _tryBlock (assert.js:320:5)
      at _throws (assert.js:339:12)
      at Function.throws (assert.js:369:3)
      at Context.<anonymous> (test/binding.js:15:14)
  2) binding missing error should list currently installed bindings:
     Error: Node Sass does not yet support your current environment: Unsupported platform (unknown) 64-bit with Node.js 6.x
For more information on which environments are supported please see:
https://github.com/sass/node-sass/releases/tag/v4.13.0
      at module.exports (lib/binding.js:13:13)
      at test/binding.js:28:22
      at _tryBlock (assert.js:320:5)
      at _throws (assert.js:339:12)
      at Function.throws (assert.js:369:3)
      at Context.<anonymous> (test/binding.js:27:14)

@nschonni
Copy link
Contributor

It would also need to be added to the known architectures like in #2783

@saper
Copy link
Member

saper commented Nov 16, 2019

@nschonni I think we should fix those tests...

jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this issue Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants