Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2394: sourceMap option should have consistent behaviour #2754

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@saper
Copy link
Member

@saper saper commented Oct 17, 2019

render() and renderSync() should return "map" property in the results
only if source map has been enabled.

@saper
Copy link
Member Author

@saper saper commented Oct 18, 2019

Related #2501

@saper saper moved this from Backlog to Review in Documentation Oct 18, 2019
render() and renderSync() should return "map" property in the results
only if source map has been enabled.
@saper saper force-pushed the saper:no-map-if-not-requested branch from bc6e11a to 8498f70 Oct 21, 2019
@saper saper requested review from xzyfer and nschonni Oct 23, 2019
@xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Oct 24, 2019

This is potentially a brrakky change but I'm happy to move forward since a it's how the docs always said it worked

@xzyfer xzyfer merged commit fbc9ff5 into sass:master Oct 24, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 75.148%
Details
@saper
Copy link
Member Author

@saper saper commented Oct 24, 2019

Thanks. I hope to get documentation to the level where it can actually be used as the requirements document :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.