Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add GitHub Actions for Alpine CI #2823

Merged
merged 1 commit into from Apr 23, 2020

Conversation

@nschonni
Copy link
Contributor

@nschonni nschonni commented Jan 18, 2020

Adds some CI for the Alpine images to speed up releases.
If this works out, I might take a look at converting some of the others.
This also uploads the artifacts as a zip on successful builds. This could be modified to only run on tags later

Note: ran into an issue with the Node 8.17.0 alpine images. You can see an example log here https://gist.github.com/nschonni/491cd2ae724e1f24db3b76b37698ab1c
Main issues is probably around

2020-01-18T03:50:16.3975372Z npm ERR! Command failed: git clone --mirror -q https://github.com/sass/sass-spec.git /github/home/.npm/_cacache/tmp/git-clone-dbd532b1/.git
2020-01-18T03:50:16.3975793Z npm ERR! /github/home/.npm/_cacache/tmp/git-clone-dbd532b1/.git: Permission denied

where the git sass-spec is failing. Tried a bunch of troubleshooting, but just decided to pin to the previous version that was working.

PS: I don't think the CI will show up till this lands, but you can see the build here https://github.com/nschonni/node-sass/commit/c288e6067650d9ebd11980c6e320e8b409f422d8/checks?check_suite_id=407548884

@xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Jan 19, 2020

This looks like something would do easily enough with Travis CI but I'm curious to see how this compares.

Loading

xzyfer
xzyfer approved these changes Jan 19, 2020
node:
- 6
- 8.16.2 # Something in 8.17.0 is breaking NPM cache install
- 10
Copy link
Contributor

@xzyfer xzyfer Jan 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give #2822 we'll want to use 10.16

Loading

Copy link
Contributor Author

@nschonni nschonni Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run into this one in the testing, can you give an example of what Alpine version you hit the issue with?

Loading

Copy link
Contributor

@xzyfer xzyfer Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end the gist of the problem appears to be that binaries built on newer alpine version didn't work on older alpine versions. I think most alpine docker images come 3.9, 3.10, 3.11, so we'll probably want to build binaries in whatever the lowest is for the specific node version.

Loading

Copy link
Contributor Author

@nschonni nschonni Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, there are tags that include the Alpine version, so I can take a look at aligning that details to the run

Loading

Copy link
Contributor Author

@nschonni nschonni Apr 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pinned them to the oldest versions now

Loading

@nschonni nschonni force-pushed the alpine-docker-build branch 4 times, most recently from da2ad01 to 38fb64d Apr 11, 2020
@nschonni nschonni force-pushed the alpine-docker-build branch from 38fb64d to 7e1d443 Apr 21, 2020
@nschonni
Copy link
Contributor Author

@nschonni nschonni commented Apr 22, 2020

Added v14, but it seems like GitHub is using an image cache that is missing it right now https://github.com/nschonni/node-sass/runs/607236373

Loading

@xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Apr 22, 2020

I'm having the same issue trying to build the binary locally. Might be dockerhub struggling after today's EC2 issues.

Loading

@xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Apr 22, 2020

I've got the Linux and pax binaries built locally. I'll cut a minor release tonight.

Loading

@nschonni nschonni force-pushed the alpine-docker-build branch from 7e1d443 to ec5eff4 Apr 22, 2020
@nschonni
Copy link
Contributor Author

@nschonni nschonni commented Apr 22, 2020

Loading

@xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Apr 23, 2020

Feel free to ship this when you're ready @nschonni

Loading

@xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Apr 23, 2020

This is super cool btw.

Loading

@nschonni nschonni merged commit aa193f6 into sass:master Apr 23, 2020
1 of 3 checks passed
Loading
@nschonni nschonni deleted the alpine-docker-build branch Apr 23, 2020
@nschonni
Copy link
Contributor Author

@nschonni nschonni commented Apr 23, 2020

Lets give it a shot. If it works out, we can cherrypick something for v5. It's possible that Actions could replace most of the CI once we don't need the old VS & Node versions there

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants