Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use default Apline version from docker-node #3121

Merged
merged 3 commits into from Jun 2, 2021

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented May 31, 2021

Matching the current defaults from https://github.com/nodejs/docker-node/blob/main/versions.json
A bunch of the current defaults are EOL versions of Alpine, so the tags are out of date

@nschonni nschonni force-pushed the nschonni-default-alpine branch from 6d794f0 to 7e69833 Compare May 31, 2021
@nschonni nschonni requested review from saper and xzyfer Jun 1, 2021
xzyfer
xzyfer approved these changes Jun 1, 2021
Copy link
Contributor

@xzyfer xzyfer left a comment

Lgtm. Can we get by without even specifying the minor?

@nschonni
Copy link
Contributor Author

nschonni commented Jun 1, 2021

Yes, there are tags for just plain 16-alpine that could be used. I'm not sure why I chose the previous ones before, but I was thinking it was probably the minimum supported version of Alpine for each Node version.
I'm fine with dropping the version, if this is just aligning it with the default version anyway.

xzyfer
xzyfer approved these changes Jun 2, 2021
@nschonni nschonni merged commit cfcbb2c into master Jun 2, 2021
32 of 34 checks passed
@nschonni nschonni deleted the nschonni-default-alpine branch Jun 2, 2021
xzyfer pushed a commit that referenced this issue Jun 24, 2021
* chore: Use default Apline version from docker-node

* chore: Add python version to CI matrix

* chore: Use default Alpine image for each version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants