From 00873b0af85133edc953a8ccb0fa20db1be66d26 Mon Sep 17 00:00:00 2001 From: Natalie Weizenbaum Date: Fri, 16 Mar 2018 13:49:28 -0700 Subject: [PATCH] Allow mod 0 (#2486) --- doc-src/SASS_CHANGELOG.md | 2 ++ lib/sass/script/value/number.rb | 1 + 2 files changed, 3 insertions(+) diff --git a/doc-src/SASS_CHANGELOG.md b/doc-src/SASS_CHANGELOG.md index b96bb1d7c..361b4869c 100644 --- a/doc-src/SASS_CHANGELOG.md +++ b/doc-src/SASS_CHANGELOG.md @@ -11,6 +11,8 @@ * Don't crash on custom properties that aren't followed by semicolons. * Don't crash when normalizing numbers with complex units. + +* Don't crash on `$x % 0`. ## 3.5.5 (4 January 2018) diff --git a/lib/sass/script/value/number.rb b/lib/sass/script/value/number.rb index 068c6cf22..9c2139369 100644 --- a/lib/sass/script/value/number.rb +++ b/lib/sass/script/value/number.rb @@ -189,6 +189,7 @@ def div(other) # @raise [Sass::UnitConversionError] if `other` has incompatible units def mod(other) if other.is_a?(Number) + return Number.new(Float::NAN) if other.value == 0 operate(other, :%) else raise NoMethodError.new(nil, :mod)