New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CSS min() and max() #77

Open
nex3 opened this Issue Jul 25, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@nex3
Contributor

nex3 commented Jul 25, 2018

@nex3 nex3 added the enhancement label Jul 25, 2018

@jakob-e jakob-e referenced this issue Jul 25, 2018

Open

CSS min() and max() re-introduced #2378

3 of 5 tasks complete
@sean0x42

This comment has been minimized.

Show comment
Hide comment
@sean0x42

sean0x42 Aug 19, 2018

@nex3 I believe you've linked the wrong issue here. It should be sass/sass#2378. Also, if I can wrap my head around the code base a little I'm happy to try and implement this.

sean0x42 commented Aug 19, 2018

@nex3 I believe you've linked the wrong issue here. It should be sass/sass#2378. Also, if I can wrap my head around the code base a little I'm happy to try and implement this.

@nex3

This comment has been minimized.

Show comment
Hide comment
@nex3

nex3 Aug 20, 2018

Contributor

I believe you've linked the wrong issue here. It should be sass/sass#2378.

Fixed, thanks!

Also, if I can wrap my head around the code base a little I'm happy to try and implement this.

That would be great! The lexer is probably the place to start, since it handles parsing functions like calc().

Contributor

nex3 commented Aug 20, 2018

I believe you've linked the wrong issue here. It should be sass/sass#2378.

Fixed, thanks!

Also, if I can wrap my head around the code base a little I'm happy to try and implement this.

That would be great! The lexer is probably the place to start, since it handles parsing functions like calc().

@sean0x42

This comment has been minimized.

Show comment
Hide comment
@sean0x42

sean0x42 Aug 23, 2018

@nex3 This probably seems like a stupid question... but how do I actually run the program for testing? I've managed to run the tests and make some changes but I have no idea how to try running the project with a Sass file.

sean0x42 commented Aug 23, 2018

@nex3 This probably seems like a stupid question... but how do I actually run the program for testing? I've managed to run the tests and make some changes but I have no idea how to try running the project with a Sass file.

@nex3

This comment has been minimized.

Show comment
Hide comment
@nex3

nex3 Aug 28, 2018

Contributor

ruby bin/sass.rb path/to/file.scss should do it.

Contributor

nex3 commented Aug 28, 2018

ruby bin/sass.rb path/to/file.scss should do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment