Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for /-as-separator #1399

Open
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@nex3
Copy link
Contributor

commented Jun 4, 2019

See sass/sass#2565

[skip dart-sass]

@nex3 nex3 requested a review from jathak Jun 4, 2019

@nex3

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

This shouldn't be submitted until:

@nex3 nex3 force-pushed the division-deprecation branch from d8491e2 to 13b483d Jun 4, 2019

@jathak

jathak approved these changes Jun 11, 2019

More info and automated migrator: https://sass-lang.com/d/slash-div

,
23 | l: 15 / 5 / $three;

This comment has been minimized.

Copy link
@jathak

jathak Jun 11, 2019

Member

Shouldn't there be a warning for the 15 / 5 part of this expression too? (it wouldn't be division on its own, but as part of the larger expression it is)

This comment has been minimized.

Copy link
@nex3

nex3 Jun 12, 2019

Author Contributor

Good question! Rather than adding another warning, I've updated the recommendation to convert nested divisions to divide() calls as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.