Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make list function specs style-guide-compliant #1416

Merged
merged 12 commits into from Jul 2, 2019

Conversation

Projects
None yet
3 participants
@nex3
Copy link
Contributor

commented Jun 27, 2019

No description provided.

Move existing list specs into core_functions/list
This also cleans up the join specs a bit.

@nex3 nex3 requested a review from jathak Jun 27, 2019

@nex3 nex3 force-pushed the list-fn branch from dc0f8ab to 3f400a0 Jun 27, 2019

@nex3

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

@jathak Hold off on this one for a bit... I want to make the specs around undefined list separators more thorough

@nex3 nex3 removed the request for review from jathak Jun 27, 2019

@nex3 nex3 force-pushed the list-fn branch from 3f400a0 to 4041b04 Jun 27, 2019

@nex3 nex3 requested a review from jathak Jun 27, 2019

@nex3

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

Okay, it's good to go! Thanks for your patience—I ran into some weird edge cases and I wanted to make sure they were fully specced out.

@jathak

jathak approved these changes Jul 1, 2019

Show resolved Hide resolved spec/core_functions/list/join/multi.hrx

@nex3 nex3 force-pushed the list-fn branch from 4041b04 to efabfbc Jul 2, 2019

@nex3 nex3 merged commit 11dc448 into master Jul 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nex3 nex3 deleted the list-fn branch Jul 2, 2019

@mgreter

This comment has been minimized.

Copy link
Contributor

commented on lib/sass_spec/engine_adapter.rb in e4e3357 Jul 8, 2019

This change fails if we're not running from within the spec directory, e.g.
ruby sass-spec/sass-spec.rb -c sassc/bin/sassc --impl libsass sass-spec/spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.