Permalink
Browse files

Change mixin name from "iphone" to "smartphone"

While mixin content blocks is an awesome feature, detecting specific devices/OS:s in CSS is error prone and a practice that should not be encouraged.

The example in the change log suggests detecting the iPhone by checking the viewport width, which is an incorrect approach. Even if examples are not meant to be used as is in production, it is still likely that they will influence developers.

Maybe smartphone is not the best name either, but at least it's better in my opinion.
  • Loading branch information...
1 parent d95f5b5 commit 2632f8b6867b1c4680ffb09cd8d664a61b1a894f @jacobrask jacobrask committed Aug 15, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 doc-src/SASS_REFERENCE.md
@@ -2164,7 +2164,7 @@ passed block are related to the other styles around where the block is defined.
#sidebar {
$sidebar-width: 300px;
width: $sidebar-width;
- @include iphone {
+ @include smartphone {
width: $sidebar-width / 3;
}
}

0 comments on commit 2632f8b

Please sign in to comment.