New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaped semicolon gets removed in compressed mode #1932

Closed
mgreter opened this Issue Dec 13, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@mgreter

mgreter commented Dec 13, 2015

This is against latest ruby sass 3.4.20
Some regression in existing spec test
libsass-closed-issues/issue_1098

div {
 color: #f00000\9\0\;
}

Results in

div{color:#f00000\9\0\}

It should not omit the escaped semicolon here, since output in other modes is

div {
  color: #f00000\9\0\;; }

I guess the compression is not smart enough to see the escape sequence ...

@chriseppstein

This comment has been minimized.

Show comment
Hide comment
@chriseppstein

chriseppstein Dec 14, 2015

Member

This worked in 3.4.17, broke in 3.4.18.

Regression was introduced by 0a80009.

Member

chriseppstein commented Dec 14, 2015

This worked in 3.4.17, broke in 3.4.18.

Regression was introduced by 0a80009.

@chriseppstein

This comment has been minimized.

Show comment
Hide comment
@chriseppstein

chriseppstein Dec 14, 2015

Member

Good catch, @mgreter.

Member

chriseppstein commented Dec 14, 2015

Good catch, @mgreter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment