Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Rebuild sourcemaps in the watch/update modes #540

Merged
merged 4 commits into from Nov 2, 2012

Conversation

Projects
None yet
2 participants

crdev commented Oct 9, 2012

This patch adds the capability to rebuild sourcemaps in the --watch and --update modes.

I think it would be cleaner to pass sourcemap_filename into Engine#render_with_sourcemap so that it can encapsulate adding the sourceMappingURL comment.

nex3 commented on 493bcdc Oct 12, 2012

This looks good. One additional thing that would be nice is to have --watch and --update print notifications when the sourcemap files are being overwritten, like they do for the CSS files. This may involve passing an additional argument to run_updated_stylesheet.

crdev commented Oct 22, 2012

I've addressed both items. Sourcemap filename is now passed into render_with_sourcemap in the form of a non-encoded URI, and into the updating_stylesheet and updated_stylesheet callbacks as plain name (like foo.css.map), notifications about sourcemap updates printed next to the css updates.

I don't think it does. StalenessChecker just checks mtimes, and in all normal circumstances the mtime of the sourcemap will be the same as the CSS.

@nex3 nex3 merged commit d2a20b7 into sass:sourcemap Nov 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment