Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random function #968

Merged
merged 3 commits into from Feb 1, 2014
Merged

Random function #968

merged 3 commits into from Feb 1, 2014

Conversation

@chriseppstein
Copy link

@chriseppstein chriseppstein commented Oct 15, 2013

Lots of people at SassConf want this. so here it is.

@chriseppstein
Copy link
Author

@chriseppstein chriseppstein commented Dec 12, 2013

@nex3 Please review. You promised this would get into 3.3. Though you may have been too drunk to remember. But I have a witness: @Snugug ;)

@Snugug
Copy link

@Snugug Snugug commented Dec 12, 2013

I am a witness!

On Dec 11, 2013, at 8:04 PM, Chris Eppstein notifications@github.com wrote:

@nex3 Please review. You promised this would get into 3.3. Though you may have been too drunk to remember. But I have a witness: @Snugug ;)


Reply to this email directly or view it on GitHub.

# @return [Integer] The same seed.
def self.random_seed=(seed)
@random_number_generator = Random.new(seed)
seed
Copy link
Contributor

@nex3 nex3 Dec 14, 2013

This is unnecessary; Ruby automatically returns the right-hand side of an assignment, even if the assignment method itself doesn't return its argument. Similarly, the doc comment describing this return value is unnecessary.

@nex3
Copy link
Contributor

@nex3 nex3 commented Dec 14, 2013

Done reviewing (and I remember agreeing to this, don't worry).

nex3 added a commit that referenced this issue Feb 1, 2014
@nex3 nex3 merged commit c7d5bf2 into master Feb 1, 2014
1 check passed
@nex3 nex3 deleted the random_function branch Feb 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants