Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import once #21

Closed
pkmiec opened this issue Jun 3, 2015 · 7 comments
Closed

import once #21

pkmiec opened this issue Jun 3, 2015 · 7 comments

Comments

@pkmiec
Copy link

pkmiec commented Jun 3, 2015

I'm trying to use sassc-rails to speed up asset compilation. With sass-rails, I've been using https://github.com/Compass/compass/tree/master/import-once. However, that doesn't seem to work with sassc-rails. Does anything like that exist yet for sassc-rails?

ps. I know sass v4 is rumored to include import once functionality. It's unclear when v4 will be out, so I'm looking for something I can use with v3.

@bolandrm
Copy link
Member

bolandrm commented Jun 3, 2015

Hey. You're correct - this won't work with sassc-rails. This could probably exist as a separate gem. It might even be simpler, since we're not doing any caching with sassc-rails.

I don't immediately need this, so i'm going to mark it as needs-contributor. Someone is welcome to work on this.

@pkmiec
Copy link
Author

pkmiec commented Jun 3, 2015

Thanks. I will look into it. Perhaps I can come up with a separate gem solution for sassc-rails.

@pkmiec
Copy link
Author

pkmiec commented Jun 5, 2015

I have written the initial version: http://github.com/appfolio/sassc-import_once. However, there seems to be an issue with libsass which prevents "import once" type of functionality, sass/libsass#1262.

@rubenswieringa
Copy link

@pkmiec can you confirm that the breadth-first/depth-first issue has been solved as stated in sass/libsass#1262?

And I noticed your gem isn't available through rubyforge yet, is there any more work that needs to be done on it?

@pkmiec
Copy link
Author

pkmiec commented Oct 16, 2015

I'm on vacation for the next week. I can look into it when I get back.

@rubenswieringa
Copy link

Cool, let me know :)

@pkmiec
Copy link
Author

pkmiec commented Nov 6, 2015

@rubenswieringa

Indeed, the issue is fixed. Hooray! I've updated the gem to depend on sassc ~> 1.8 and enabled additional tests. The first version of the gem is now available on rubygems.

I've yet to use this on my own project, so let me know if it work / doesn't work for you.

@pkmiec pkmiec closed this as completed Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants