Fix function name formats #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanPurdy
force-pushed
the
feature/fix-function-name-format
branch
from
3b05495
to
80ea774
Compare
|
Need to add all the sass functions too |
|
TODO:
|
|
Ready for review |
|
LGTM. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed #434 The function name format rule wasn't taking into account a lot of default CSS function names.
After trawling the web for as definitive list as possible I've added my findings to the whitelist. Some of the functions are either very very early in the w3c draft process or have even lost support in most of the browsers around today but I feel it's important to keep them there out of completeness sake
closes #434
Again not sure it's worth a hotfix when 1.4.0 is around the corner
DCO 1.1 Signed-off-by: Dan Purdy danjpurdy@gmail.com