-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct typos and add jsdoc comment to pseudo-element rule #682
Conversation
@@ -12,20 +12,38 @@ var pseudoElements = yaml.safeLoad( | |||
fs.readFileSync(path.join(__dirname, '../../data', 'pseudoClasses.yml'), 'utf8') | |||
).split(' '); | |||
|
|||
/** | |||
* Get prefix free version of string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a great comment, Maybe 'Checks if the supplied argument is a string and contains a prefix, if it does we remove the prefix'.
Who did the PR to this rule originally I ask!? 😄 😉 Also you've gotten back into your shorthand comments again.. I think the descriptions could be better, more formed english... |
Fixes a few typos in the rule file and adds some basic jsdoc comments.
DCO 1.1 Signed-off-by: Ben Griffith gt11687@gmail.com