Refactor: Single source of truth for site URL#143
Conversation
|
Which problem can occur when we use or don't use |
|
Since the config file has a .ts extension it's not semantically correct to import a uncompiled .ts file into .mjs file. Btw no error for me on remarkToc for both .mjs or .ts |
|
This works for me too— thanks for the update @tanishqmanuja |
|
In order to resolve the type error, I had to update the dependencies to the latest one. |
satnaing
left a comment
satnaing
left a comment
There was a problem hiding this comment.
Just make some minor updates on my own.
astro.config.ts
Outdated
| // https://astro.build/config | ||
| export default defineConfig({ | ||
| site: "https://astro-paper.pages.dev/", // replace this with your deployed domain | ||
| site: SITE.website, // replace this with your deployed domain |
There was a problem hiding this comment.
Can you remove (or update) the comment here?
I think this comment is no longer relevant here. Maybe it can be inside the src/config.
|
@satnaing, can you add hacktoberfest tag to the repo till nov 1, would be great 😸 |
|
@tanishqmanuja On the other hand, I'm also thinking of participating in Hacktoberfest. |
|
I personally think there wouldn't be lots of requests. Plus there is no negative outcome in the case there are, We could solve them one by one as usual :) |
* wip: astro config to use .ts instead of .mjs * fix: remove invalid prop in astro config * refactor: single source of truth for site url * refactor: make minor updates due to astro.config.ts --------- Co-authored-by: satnaing <satnaingdev@gmail.com>
3 participants
Note:
related: #142