Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLIP 132: Mention multisignature script type for Yp and Zp prefixed keys #531

Merged
merged 3 commits into from Mar 1, 2019

Conversation

Projects
None yet
3 participants
@afk11
Copy link
Contributor

afk11 commented Feb 13, 2019

Late follow up, but hope this is an acceptable fix for #315

Really don't like handling these as multisig without being able to refer to the spec.

@clarkmoody

This comment has been minimized.

Copy link
Contributor

clarkmoody commented Feb 14, 2019

The xpub encoding story continues to be a disaster. I'm not sure we've made any headway over the past 18 months, expect the draft SLIP-32?

Tracing through the Electrum source, this looks like what they're doing, so it's an ACK from me. It would be much more helpful to have a BIP describing the address encoding scheme?

@afk11

This comment has been minimized.

Copy link
Contributor Author

afk11 commented Feb 15, 2019

@clarkmoody thanks for review!

As far as I can tell, the P2SH usage in 'p2pkh or p2sh' is also multisignature. Would it be ok to submit this also?

Also, I forgot to apply the changes to other networks - I'll follow up with that now!

afk11 added some commits Nov 7, 2018

@afk11 afk11 force-pushed the afk11:slip132-script-hash-types branch from fe52a1f to 06ae8f9 Feb 15, 2019

@clarkmoody

This comment has been minimized.

Copy link
Contributor

clarkmoody commented Mar 1, 2019

I would re-order the rows of Testnet to match the mainnet rows (put multisig rows together).

@afk11

This comment has been minimized.

Copy link
Contributor Author

afk11 commented Mar 1, 2019

@clarkmoody good catch, I've pushed this now

@clarkmoody

This comment has been minimized.

Copy link
Contributor

clarkmoody commented Mar 1, 2019

👍 LGTM

CC: @prusnak

@prusnak prusnak merged commit 9d6950e into satoshilabs:master Mar 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@prusnak

This comment has been minimized.

Copy link
Member

prusnak commented Mar 1, 2019

Thx!

@afk11 afk11 deleted the afk11:slip132-script-hash-types branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.