Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slip-0044: add STASH #613

Merged
merged 1 commit into from Apr 30, 2019

Conversation

Projects
None yet
2 participants
@BeachM
Copy link
Contributor

commented Apr 29, 2019

No description provided.

@prusnak

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

use the first available value

@BeachM

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@prusnak sincere apologies for the out of order index. Is it possible to make an exception? in this case The reason I ask is that we have live wallets deployed already using current index.

https://github.com/iancoleman/bip39/blob/master/src/js/index.js#L2533
https://github.com/stashpayio/stash/blob/master/src/chainparams.cpp#L238

@prusnak

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Meh, it was irresponsible to start using the value without allocating it first.

@prusnak prusnak merged commit e6fa429 into satoshilabs:master Apr 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BeachM

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

Agreed. Lesson learnt for future. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.