Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cruzbit #693

Merged
merged 1 commit into from Jul 12, 2019

Conversation

Projects
None yet
3 participants
@GreenAppers
Copy link
Contributor

commented Jul 10, 2019

No description provided.

@prusnak

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

use the first available number

@asdvxgxasjab

This comment has been minimized.

Copy link

commented Jul 11, 2019

use the first available number

We're already using this number. There's already tons of sparse entries in the list. What's the problem?

@prusnak

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

the problem is you have started using the number before allocating it first

@GreenAppers

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

Right. We already launched using this number. We have users with substantial cruzbit holdings in HD wallets generated using 831 as the coin type. We can't change at this point.

I've updated our documentation to refer to https://github.com/GreenAppers/slips and we will continue to maintain the fork.

For future reference the criteria of "use the first available number" should be documented more prominently. SLIP-0044 is filled with counter examples and there is no such indication that I've seen before your comment.

@asdvxgxasjab

This comment has been minimized.

Copy link

commented Jul 11, 2019

Par for the course in bitcoin land. Give someone a modicum of power and they wield it forcefully and arbitrarily. This was just a heads' up. Add the number or don't but we're going to use it.

@prusnak prusnak closed this Jul 12, 2019

@prusnak prusnak reopened this Jul 12, 2019

@prusnak prusnak merged commit 47c312b into satoshilabs:master Jul 12, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.