Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICON's coin type value #719

Closed
wants to merge 1 commit into from

Conversation

@cwkwak
Copy link

commented Aug 5, 2019

ICON has used 0x80494358 for the coin type. (applied to ledger app)

Fix ICON's coin type value
ICON has used 0x80494358 for the coin type. (applied to ledger app)
@prusnak

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

Fix the ledger app to use the correct number.

@prusnak prusnak closed this Aug 5, 2019

@cwkwak

This comment has been minimized.

Copy link
Author

commented Aug 5, 2019

We released the ledger app about 1 year ago. Many users have already created and used keys. Could you accept my pull request?

@prusnak

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

Why haven't you used the assigned number?

@prusnak

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

Also, no, I am not changing the assigned number. There is no way how to determine how many applications are there which use the correct number .

@cwkwak

This comment has been minimized.

Copy link
Author

commented Aug 5, 2019

1 year ago, it was not defined. One of our team members was supposed to register this number, but he missed. Recently I found out and submitted the pull request.
I’ll check with the person to register 4a where he’s ever used it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.