Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slip-0022: Create SLIP-0022. #724

Merged
merged 3 commits into from Aug 12, 2019

Conversation

@andrewkozlik
Copy link
Contributor

commented Aug 8, 2019

@onvej-sl please check the examples.

@andrewkozlik andrewkozlik requested a review from onvej-sl Aug 8, 2019

@onvej-sl
Copy link

left a comment

Examples are OK, but there a few things that were a little confusing for me:

A CredentialData DOM object defined as follows:

Why is the object called "DOM" object?

3: h'3082019330820138A0030201023082019330820138A003020102308201933082',

What is the meaning of the "h" prefix?

@andrewkozlik andrewkozlik force-pushed the andrewkozlik/slip-0022 branch from 050e5c0 to 0ae4d68 Aug 9, 2019

@andrewkozlik

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

Examples are OK, but there a few things that were a little confusing for me:

A CredentialData DOM object defined as follows:

Why is the object called "DOM" object?

3: h'3082019330820138A0030201023082019330820138A003020102308201933082',

What is the meaning of the "h" prefix?

I just reused the terminology and notation from the CTAP spec without giving it much thought, but I agree it would be better to be more precise here and talk about a "credential data object in CBOR diagnostic notation". See RFC 7049.

@andrewkozlik andrewkozlik merged commit 0e9a591 into master Aug 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.