Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Lava to slip-0044 #811

Merged
merged 3 commits into from Nov 8, 2019

Conversation

@jiraiyav5
Copy link
Contributor

jiraiyav5 commented Nov 4, 2019

No description provided.

@prusnak

This comment has been minimized.

Copy link
Member

prusnak commented Nov 4, 2019

use the first available number

@jiraiyav5

This comment has been minimized.

Copy link
Contributor Author

jiraiyav5 commented Nov 5, 2019

@prusnak Thanks !
I reback the code and use an available number !

@prusnak

This comment has been minimized.

Copy link
Member

prusnak commented Nov 5, 2019

use the first available number!

@jiraiyav5

This comment has been minimized.

Copy link
Contributor Author

jiraiyav5 commented Nov 6, 2019

Hi prusnak, i used the not used number 888888 ! what is your mean "first available number"? you means that i should use index 438 ?

@prusnak

This comment has been minimized.

Copy link
Member

prusnak commented Nov 6, 2019

according to https://github.com/satoshilabs/slips/blob/master/slip-0044.md the first available is 443 at the moment

@jiraiyav5

This comment has been minimized.

Copy link
Contributor Author

jiraiyav5 commented Nov 8, 2019

Hi prusnak,
Thanks for your direction ! I hava updated Lava index to 443 (first available number).
Please help check and merge !

@prusnak prusnak merged commit 19ae21e into satoshilabs:master Nov 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.