Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slip-0022: Add algorithm field. #816

Merged
merged 2 commits into from Dec 4, 2019

Conversation

@andrewkozlik
Copy link
Contributor

andrewkozlik commented Nov 12, 2019

No description provided.

@andrewkozlik andrewkozlik requested a review from onvej-sl Nov 12, 2019
@andrewkozlik andrewkozlik force-pushed the andrewkozlik/slip-0022 branch from 11e49b9 to 163f43c Nov 12, 2019
@onvej-sl

This comment has been minimized.

Copy link

onvej-sl commented Nov 18, 2019

I'm not sure whether I understand what is the purpose of the curve field. Is its purpose to distinguish between Ed25519 and Ed448 if the algorithm is EdDSA?

If we are planning to use another algorithm that needs parameters in future we might want create a nested structure called algorithmParameters.

@andrewkozlik andrewkozlik force-pushed the andrewkozlik/slip-0022 branch from 163f43c to ed924f8 Nov 20, 2019
@andrewkozlik

This comment has been minimized.

Copy link
Contributor Author

andrewkozlik commented Dec 4, 2019

I'm not sure whether I understand what is the purpose of the curve field. Is its purpose to distinguish between Ed25519 and Ed448 if the algorithm is EdDSA?

Yes.

If we are planning to use another algorithm that needs parameters in future we might want create a nested structure called algorithmParameters.

As discussed in meeting, we want to keep the structure flat.

@@ -186,6 +192,7 @@ The rationale behind using the authentication tag for the SLIP-0010 key path is

* [Web Authentication](https://www.w3.org/TR/webauthn/): An API for accessing Public Key Credentials Level 1, W3C Recommendation, 4 March 2019
* [FIDO Client to Authenticator Protocol (CTAP) v2.0](https://fidoalliance.org/specs/fido-v2.0-ps-20190130/fido-client-to-authenticator-protocol-v2.0-ps-20190130.html#sctn-hmac-secret-extension), Proposed Standard, January 30, 2019
* [IANA-COSE-REG](https://www.iana.org/assignments/cose/cose.xhtml#algorithms): IANA CBOR Object Signing and Encryption (COSE) Registries.

This comment has been minimized.

Copy link
@onvej-sl

onvej-sl Dec 4, 2019

Should be without #algorithms at the end of the url.

Copy link

onvej-sl left a comment

Just one typo.

@andrewkozlik andrewkozlik force-pushed the andrewkozlik/slip-0022 branch from ed924f8 to 1c0f6c9 Dec 4, 2019
@andrewkozlik andrewkozlik merged commit 535daca into master Dec 4, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@andrewkozlik andrewkozlik deleted the andrewkozlik/slip-0022 branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.