Implement emissive strength for PBR materials#190
Merged
saturday06 merged 2 commits intosaturday06:mainfrom Jan 27, 2023
Merged
Implement emissive strength for PBR materials#190saturday06 merged 2 commits intosaturday06:mainfrom
saturday06 merged 2 commits intosaturday06:mainfrom
Conversation
Owner
|
OK. I'll tweak your commit and merge it later. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for exporting emissive strength/intensity on PBR materials in VRM via the
KHR_materials_emissive_strengthextension.https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_materials_emissive_strength
Our users want to use HDR bloom so that parts of their avatar glow like this:
While the code works, i'm not entirely familiar with python or blender plugins so happy to improve this based on any feedback you may have.