This repository was archived by the owner on Nov 27, 2022. It is now read-only.
feat: macOS and Windows support #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Hey dcangulo! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
|
@satya164 Any more changes I need to make? 🎌 |
|
I'll review it this week |
|
Thanks for the PR 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
react-native-pager-viewon macOS and Windows causes errors. Solution is to usePanResponderfor these platforms (same with web).Those platforms favors
.native.tsxfile over.tsxfile which caused the errors. Solution is to use platform specific components for each.macOS fixes:
Transform property is currently broken on
react-native-macos. Temporary solution is to useleftfor indicator position. See: microsoft/react-native-macos#280Windows fixes:
PlatformPressableis not pressable on Windows (only the label), I'm not sure why, but addingbackgroundColor: 'transparent'to it makes the whole tab pressable.Motivation
react-native-pager-viewdoes not support macOS and Windows.Test plan
Run on
react-native-macosandreact-native-windowsprojects.Windows (initial):
Windows (swiping):
macOS (initial):
macOS (swiping):
macOS (swiping): if microsoft/react-native-macos#460 is merged
macOS (after swipe/swipe release):
