Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added shellArgs; version# tba. #5

Merged
merged 1 commit into from Jul 29, 2019

Conversation

@4a-42
Copy link

commented Jul 28, 2019

It seems to work as intended on my machine. only 1 loc was changed.
I'll let you decide version number.
I'm not sure what else needs to be changed/done to update the extension.

I'm a bit concerned that unit-testing isn't implemented yet. Not quite sure how to approach unit testing something like this anyways.

I also did some minor linting stuff to README.md

@saurabhdaware

This comment has been minimized.

Copy link
Owner

commented Jul 29, 2019

Hey looks great! about the version, yes i will update it before pushing to marketplace. Thank you for contributing 😄 merging this 🕺

@saurabhdaware saurabhdaware merged commit f6f202a into saurabhdaware:master Jul 29, 2019

@saurabhdaware saurabhdaware referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.