Andrew Dupont savetheclocktower

Organizations

@gowalla
savetheclocktower commented on pull request bazaarvoice/scoutfile#22
@savetheclocktower

Addressed Lon's feedback about test coverage.

@savetheclocktower
savetheclocktower commented on pull request bazaarvoice/scoutfile#22
@savetheclocktower

All feedback addressed.

@savetheclocktower
@savetheclocktower

A try/catch around the appendChild call would work, right?

@savetheclocktower
savetheclocktower commented on pull request bazaarvoice/scoutfile#22
@savetheclocktower

My last commit fleshed out the JSDoc, but I'll add that section to the Markdown documentation as well.

@savetheclocktower
savetheclocktower commented on pull request bazaarvoice/scoutfile#22
@savetheclocktower

There are lots of ways to duck-type a DOM node and none of them stands out from the rest.

@savetheclocktower
Allow `loadStyleSheet` to accept an alternative injection point.
1 commit with 35 additions and 1 deletion
@savetheclocktower

Ah. Well, that's another question — do we invoke the callback with an error, or do we throw? If the idea is to make the nature of the error more ap…

@savetheclocktower

So the points of contention are (1) who handles errors, and (2) whether we do the same thing for loadScript. And the consensus seems to be meh on b…

@savetheclocktower

My view is that this matters less for loadScript because a script still gets evaluated no matter what happens to its script node. Hence I can't thi…

@savetheclocktower
Add an `injectionNode` option to `loadStyleSheet`
@savetheclocktower

(In other words, it works with 1.7.2.)

@savetheclocktower
Scriptaculous Effect.Highlight no longer works with Prototype 1.7.1
@savetheclocktower

This got fixed in #59.

@savetheclocktower
@savetheclocktower
Bugfix for Opera compatibility
1 commit with 1 addition and 1 deletion
savetheclocktower commented on pull request sstephenson/prototype#297
@savetheclocktower

That's fair enough.

@savetheclocktower
IE: getOffsetParent returns body instead of relative positioned parent element
@savetheclocktower

Yeah, looks that way on closer inspection. Closing.

savetheclocktower commented on pull request sstephenson/prototype#297
@savetheclocktower

Now that I notice you're the original author of this ticket: first, apologies it took me so long to deal with it one way or another. Second: can yo…

@savetheclocktower
Element.clone() does not copy selectedIndex property for select-elements
@savetheclocktower
evalScripts() function fails with HTML comments
@savetheclocktower

I need to investigate whether this is still happening.

@savetheclocktower
The following error occures
@savetheclocktower

Marking this as an enhancement just because I have no idea what we should do in this scenario.