New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dht] rework get timings after queries in master #106

Merged
merged 2 commits into from Aug 9, 2016

Conversation

Projects
None yet
2 participants
@sim590
Contributor

sim590 commented Aug 6, 2016

After merging queries in master, there are two things that I didn't get right:

  • When a 'get' request associated with a certain 'query' has been sent, we don't want to send it again, i.e. we don't care if it's pending or not as soon as it has been sent.
  • Search::isDone doesn't need to compute with a time reference. It simply has to check its search nodes requests status.

sim590 added some commits Aug 6, 2016

search: isDone computes using Request interface
There's no need to compute with time since the network engine gives us the
information we need.
dht: fixing timing in SearchNode::canGet
When a 'get' request associated with a certain 'query' has been sent, we don't
want to send it again, i.e. we don't care if it's pending or not as soon as it
has been sent.

@sim590 sim590 added the enhancement label Aug 6, 2016

@sim590 sim590 added this to the Data persistence milestone Aug 6, 2016

@aberaud aberaud merged commit 86d837b into savoirfairelinux:master Aug 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment