New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pht: fix invalid comparison, inexact match lookup #77

Merged
merged 1 commit into from Jun 15, 2016

Conversation

Projects
None yet
2 participants
@sim590
Contributor

sim590 commented Jun 14, 2016

This is a change around the code doing the inexact match lookup. The algorithm should check the number of common bits between the target prefix and candidate prefix found in the leaves. However, by error, the code was comparing the target prefix with the wrong data: the indexed hash rather than the prefix key for that index entry.

@kaldoran, @aberaud: It's been a while since I worked on this part of the code. Can you review this?

@sim590 sim590 added the bug label Jun 14, 2016

@sim590 sim590 added this to the Pht indexation milestone Jun 14, 2016

@kaldoran

This comment has been minimized.

Show comment
Hide comment
@kaldoran

kaldoran Jun 15, 2016

Collaborator

Forget to comment about it yesterday but all seams ok for me.

Collaborator

kaldoran commented Jun 15, 2016

Forget to comment about it yesterday but all seams ok for me.

@kaldoran kaldoran merged commit 5c9a883 into savoirfairelinux:index Jun 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment