Net::HTTP::Persistent adapter #92
Conversation
Using the url of the request to generate the thread pool key.
|
thanks @mynameisrufus. i'm not sure if the current design of HTTPI (creating a new adapter per request) plays well with the net/http persistent library. @rogerleite can you take care of this? |
|
@rubiii, @mynameisrufus did a clever tricky using host as thread key ... frontfoot@2d00774#L4R35 On May i changed my job and i'm trying to find some time. We have this and excon adapter #91 to review. |
|
@rogerleite ahh i see. hit me up when you have some time. |
|
net net-http-persistent uses a pool of connections in a thread based on a key https://github.com/drbrain/net-http-persistent/blob/master/lib/net/http/persistent.rb#L594 I guess my approach would fall down if example.com/A and example.com/B ended up at different servers? |
|
sorry @mynameisrufus i don't get it. Why would fall down? |
|
No your right, it would be fine. |
|
@mynameisrufus thks! This adapter will be available at release v2.1.0 |
|
releaed with version 2.1.0. |
🍰