Skip to content
This repository
Browse code

added a basic contribution guide. again.

  • Loading branch information...
commit ea14426887e71f379506359f02482a5b7e31b200 1 parent dec3ee9
Daniel Harrington authored March 07, 2013

Showing 1 changed file with 46 additions and 0 deletions. Show diff stats Hide diff stats

  1. 46  CONTRIBUTING.md
46  CONTRIBUTING.md
Source Rendered
... ...
@@ -0,0 +1,46 @@
  1
+# Contribution Guide
  2
+
  3
+This page describes how to contribute changes to Savon.
  4
+
  5
+Please do not create a pull request without reading this guide first.
  6
+Make sure to read the documentation for your version at [savonrb.com](http://savonrb.com/)
  7
+and post questions to the [mailing list](https://groups.google.com/forum/#!forum/savonrb).
  8
+
  9
+**Bug fixes**
  10
+
  11
+If you really think you found a bug, please make sure to add as many information as possible
  12
+to the ticket. You're a developer, we are developers and you know we need tests to reproduce
  13
+problems and make sure they don't come back.
  14
+
  15
+So if you can reproduce your problem in a spec, that would be awesome! If you can't, please
  16
+let us know how we could make this easier for you. Also, provide code and the WSDL of the
  17
+service your working with so others can try to come up with a spec for your problem.
  18
+
  19
+After we have a failing spec, it obviously needs to be fixed. Make sure your new spec is the
  20
+only failing one under the `spec` directory. Travis only runs the "unit tests" at `spec/savon`,
  21
+but Savon actually has with some additional "integration/example specs" at `spec/integration`,
  22
+which you need to run locally to make sure the integration with real world services still works.
  23
+
  24
+Notice that these specs are not run by Travis, because the service's are not guaranteed to work
  25
+all the time and the specs will timeout after a few seconds when the service is currently down.
  26
+
  27
+Please follow this basic workflow for pull requests:
  28
+
  29
+* [Fork the project](https://help.github.com/articles/fork-a-repo)
  30
+* Create a feature branch and make your bug fix
  31
+* Add tests for it!
  32
+* Update the [Changelog](https://github.com/savonrb/savon/blob/master/CHANGELOG.md)
  33
+* [Send a pull request](https://help.github.com/articles/using-pull-requests)
  34
+* [Check that your pull request passes the build](https://travis-ci.org/savonrb/savon/pull_requests)
  35
+
  36
+
  37
+**Improvements and feature requests**
  38
+
  39
+If you have an idea for an improvement or a new feature, please feel free to
  40
+[create a new issue](https://github.com/savonrb/savon/issues/new) and describe your idea
  41
+so that other people can give their insights and opinions. This is also important to avoid
  42
+duplicate work.
  43
+
  44
+Pull requests and issues on GitHub are meant to be used to discuss problems and ideas,
  45
+so please make sure to participate and follow up on questions. In case noone comments
  46
+on your ticket, please keep updating the ticket with additional information.

0 notes on commit ea14426

Please sign in to comment.
Something went wrong with that request. Please try again.