Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop git ls-files in gemspec #89

Merged
merged 2 commits into from Jul 20, 2020
Merged

Conversation

utkarsh2102
Copy link
Contributor

Hi @olleolleolle,

Thanks for maintaining this so far! ❤️
As discussed in #68, this PR drops the usage of git to list the files and only ships the files that are necessary for end-users 🚀

Closes: #68

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

Closes: savonrb#68

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
@coveralls
Copy link

coveralls commented Jul 20, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling 7ce601c on utkarsh2102:drop-git into 0ee8958 on savonrb:master.

@olleolleolle
Copy link
Contributor

@utkarsh2102 To make this PR mergeable now, without any other changes, please omit the rubocop-packaging change.
It's a good idea, but other changes are needed to include it, now.

rubocop-packaging (~> 0.1.1) was resolved to 0.1.1, which depends on

      ruby (>= 2.3.0)

@utkarsh2102
Copy link
Contributor Author

Hi @olleolleolle,

Eeks, I am sorry, I should've checked! :/
How about this diff:

--- a/Gemfile
+++ b/Gemfile
@@ -5,6 +5,10 @@ gem 'simplecov',       :require => false
 gem 'method_profiler', :require => false
 gem 'coveralls',       :require => false
 
+if RUBY_VERSION >= '2.3'
+  gem 'rubocop-packaging',  :require => false
+end
+
 platform :rbx do
   gem 'json'
   gem 'racc'

I hope that's better and okay?

@olleolleolle
Copy link
Contributor

It's alright if the build gets to green, try it!

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
@utkarsh2102
Copy link
Contributor Author

Sorry for not checking the build failures earlier (my bad!).
Green again! 🎉

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

@olleolleolle olleolleolle merged commit e47045d into savonrb:master Jul 20, 2020
@utkarsh2102 utkarsh2102 deleted the drop-git branch July 20, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Gem includes heavy test files unnecessarily
3 participants