Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing commas in metadata.json #110

Closed
lvlie opened this issue Mar 13, 2015 · 2 comments
Closed

Trailing commas in metadata.json #110

lvlie opened this issue Mar 13, 2015 · 2 comments

Comments

@lvlie
Copy link

lvlie commented Mar 13, 2015

Hi,

First off, thanks for the awesome module :) There is one issue which we came accross, the metadata.json has trailing commas inside the bracketed parts on line 20 and line 23. They should not exist and json parsers (like jq) fail on it. I could write a pull request but such a small issue is probably easier fixed without :)

Thanks!

  • Leon
@pbyrne413
Copy link
Contributor

There are actually two pull requests already for this issue, so it is just a matter of when that gets merged back in.

@lvlie
Copy link
Author

lvlie commented Mar 16, 2015

Oops, missed that. Thanks for the heads up.

@lvlie lvlie closed this as completed Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants