Permalink
Browse files

Revert "Pass MAP_FIXED to mmap on Linux."

Uisng MAP_FIXED is a bad idea.

This reverts commit 55abdff.
  • Loading branch information...
stassats committed Mar 31, 2016
1 parent e9cc132 commit a10fd4e2674f0bc1bf8be0848d54f53bfa12680e
Showing with 0 additions and 4 deletions.
  1. +0 −4 src/runtime/linux-os.c
View
@@ -337,10 +337,6 @@ os_validate(os_vm_address_t addr, os_vm_size_t len)
addr=under_2gb_free_pointer;
}
#endif
if (addr)
flags |= MAP_FIXED;
actual = mmap(addr, len, OS_VM_PROT_ALL, flags, -1, 0);
if (actual == MAP_FAILED) {
perror("mmap");

1 comment on commit a10fd4e

@mjreed-turner

This comment has been minimized.

Show comment
Hide comment
@mjreed-turner

mjreed-turner Sep 28, 2016

OK, so what is the not-"bad idea" way to allow sbcl to work in the face of ASLR?

mjreed-turner commented on a10fd4e Sep 28, 2016

OK, so what is the not-"bad idea" way to allow sbcl to work in the face of ASLR?

Please sign in to comment.