New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace call to obsolete Object#to_a
with Array(str)
.
#28
Open
xnzac
wants to merge
21
commits into
sbecker:master
Choose a base branch
from
xnzac:2d05d8c32824c02ff411daa10f351f52820c9c09
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Replace call to obsolete Object#to_a
with Array(str)
.
#28
xnzac
wants to merge
21
commits into
sbecker:master
from
xnzac:2d05d8c32824c02ff411daa10f351f52820c9c09
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing asset_packager to use module and stop shuffling files / invoking ruby
…ently updated source file. This allows Rails asset IDs to work as intended - if the source files haven't been modified when a new build is done (typically at deploy time), the asset IDs will stay the same so browsers don't need to re-download.
Thanks to lannon for Google Closure Compiler support!
…st.rb run without rails environment
…kager Conflicts: lib/synthesis/asset_package.rb
This fixes an error on Ruby 1.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting undefined method String#to_a when using Ruby 1.9.2, fixed in 2d05d8c
by jasoncodes.
Sorry, I'm not sure how to do a pull request on just one commit.