Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All categories page does not work when single category budget is set to $0 #39

Closed
ActuallyConnor opened this issue Oct 4, 2020 · 4 comments

Comments

@ActuallyConnor
Copy link

When the budget is set to $0 for a category and then you try to go to the list of all the categories it errors out. If you go back to that individual category and set the value to a positive number it no longer errors out.

bdgt

@pfaffenrodt
Copy link
Contributor

I take a look

@Saibamen
Copy link
Contributor

Saibamen commented Oct 4, 2020

Please copy and paste stack trace here

@pfaffenrodt
Copy link
Contributor

I fixed the calculation. Maybe it would be better, not even to allow to create or update a budget to a value below or equal of zero

@sbine
Copy link
Owner

sbine commented Oct 4, 2020

Fixed in #43, thanks! I'm OK with allowing category budgets of 0 since you might want to skip budgeting for a month or two but not delete the category.

The budgeting feature in bdgt needs an overhaul anyway, I have a prototype implemented at /budget but don't yet have a good plan to integrate it into the rest of the UI.

@sbine sbine closed this as completed Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants