Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Lazy Bulk doc handling #67

Closed
BigBlueHat opened this Issue · 4 comments

3 participants

BigBlueHat Sam Bisbee Till!
BigBlueHat
Collaborator

If I give Sag::bulk() an absurdly large .json array full of docs, I'd love for it to split them into 1k bulk sends and/or further optimize the bulk request for me.

Otherwise, this bulk doc optimizing code gets written in "developer land" and unnecessarily slows people down.

Maybe it can throw a warning--if you'd like--for educational purposes: "Sag is optimizing your absurdly large bulk docs request. You're welcome. :hugs:"

Sam Bisbee
Owner

:+1: as long as it's configurable.

Till!

How exactly do you optimize this? Isn't absurdly the same as "YMMV"? =)

Sam Bisbee
Owner

@BigBlueHat @till Implemented in the 1.0 branch.

To @till's point, I decided to make the default size 0 so that we don't run into YMMV disagreements.

Let me know what you think.

Sam Bisbee sbisbee closed this
BigBlueHat
Collaborator

:+1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.