Composer Support #49

Merged
merged 1 commit into from Mar 20, 2013

Conversation

Projects
None yet
4 participants
Contributor

bradley-holt commented Apr 17, 2012

This change allows Sag to be used as a Composer package.

till commented Feb 11, 2013

@sbisbee Can you merge this? It would help us a lot including this code.

Owner

sbisbee commented Feb 11, 2013

@till I haven't merged it in because I have no handle on how standard Composer is. I care about this because there seems to be a ton of different PHP packaging constructs and I don't plan on supporting all of them.

I would package for PEAR, but I disagree fundamentally with some of their constraints.

However, I leave this pull request open because some folks might like to use @bradley-holt's work and there isn't anything inherently wrong with it.

My kingdom for NPM (adoption and self governance) in PHP.

Cheers.

till commented Feb 11, 2013

@sbisbee composer is very popular in the PHP world — symfony, zend framework — they all support this. I just looked at the composer.json again though. It's also missing an include-path directive so the code doesn't error with your require_once. It should probably also list cURL and socket.

A side effect/benefit of composer adoption would be to utilize the standard class loading. Generally, it's nice to allow users to do their own autoloading strategy.

With composer and github you can automatically publish your releases to http://packagist.org or a private composer repository. You don't need to update the composer.json unless you make additions to it — like a new author, or a new dependency.

I could also help you with PEAR packaging if you let me know what constraints you ran into.

till commented Feb 11, 2013

Btw — NPM as in node package manager? Composer is just that.

Collaborator

BigBlueHat commented Mar 6, 2013

+1 for merging this pre-1.0

Composer is super.

@sbisbee sbisbee added a commit that referenced this pull request Mar 20, 2013

@sbisbee sbisbee Merge pull request #49 from bradley-holt/master
Composer Support
ba7f25a

@sbisbee sbisbee merged commit ba7f25a into sbisbee:master Mar 20, 2013

till commented Mar 20, 2013

Thanks, dude!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment