New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceBans Checker to include comms blocks #188

Closed
sneak-it opened this Issue Oct 6, 2016 · 7 comments

Comments

Projects
None yet
5 participants
@sneak-it
Copy link
Contributor

sneak-it commented Oct 6, 2016

Just a bit of a suggestion/enhancement/feature request, it would be nice if the SourceBans checker plugin also counted & announced how many comms blocks a connecting user has, in similar fashion to previous # of bans being listed.

@Technoblazed

This comment has been minimized.

Copy link

Technoblazed commented Oct 6, 2016

I wrote something for this a while back, no idea where the code went though \o/. Also implemented mute evasion into sourcesleuth

@sneak-it

This comment has been minimized.

Copy link
Contributor

sneak-it commented Oct 7, 2016

@Technoblazed If you ever run across it and would like to share, I'm sure several people would be interested.

@Technoblazed

This comment has been minimized.

Copy link

Technoblazed commented Oct 7, 2016

I'll take a look for it this weekend :)

@Sarabveer

This comment has been minimized.

Copy link
Member

Sarabveer commented Oct 8, 2016

@Technoblazed if you ever find it, re-implement it with the latest version of SourceSleuth and submit a PR.

@DataWorm

This comment has been minimized.

Copy link

DataWorm commented Feb 16, 2018

Seems he didn't find it or forgot about it. Anyway I also missed that feature so I just checked the code and modified it today and in the end successfully tested it with some help. sm_listcomms is now implemented but we might try to make a few more improvements. Going to make a merge request when I am done.
Also I should mention that I never programmed on source scripts before so sorry if there is a little but code duplication which I preferred to keep it simple and avoid additional bugs.

@DataWorm

This comment has been minimized.

Copy link

DataWorm commented Feb 16, 2018

@sneak-it Job is done now. If you still need that feature you can just checkout the version from my merge request.

@Groruk

This comment has been minimized.

Copy link
Member

Groruk commented Jun 17, 2018

Added with #398

@Groruk Groruk closed this Jun 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment