New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbpp_sleuth option to exclude old bans from lookup #352

Closed
koteq opened this Issue Sep 11, 2017 · 12 comments

Comments

Projects
None yet
4 participants
@koteq
Copy link
Contributor

koteq commented Sep 11, 2017

Expected Behavior

The plugin should give an option to exclude old bans in order to decrease false positives.

Current Behavior

Some players getting false positive bans. Seems their ISP utilizes dynamic IP pools.

Possible Solution

Introduce new convar and touch this SQL query.

Context

I do maintain sourcebans instance with 10k bans (4.7k permabans) with bans from early 2013.

@Alicebnd

This comment has been minimized.

Copy link

Alicebnd commented Sep 13, 2017

Yes, this function is very necessary.

@rumblefrog

This comment has been minimized.

Copy link
Member

rumblefrog commented Sep 13, 2017

Honestly, it's called permanent ban, not sure what you're expecting. If you wish to expire it due to reliability concern, simply not ban by IP or just set the time for X years and it'll auto exclude.

@rumblefrog

This comment has been minimized.

Copy link
Member

rumblefrog commented Sep 13, 2017

Here's a quick version I made implementing that. However, it's not tested, you're warned: https://gist.github.com/RumbleFrog/d893be81dd33808bfaa6934c3dbd8c63

It contains two additional ConVars

sm_sleuth_excludeold | 0 - Inactivated, 1 - Allow old bans to be excluded from ban check
sm_sleuth_excludetime | Amount of time in seconds to allow old bans to be excluded from ban check
@Alicebnd

This comment has been minimized.

Copy link

Alicebnd commented Sep 20, 2017

Big thx.
In my opinion this works.
How to translate this into a release?

@rumblefrog

This comment has been minimized.

Copy link
Member

rumblefrog commented Sep 20, 2017

It's kinda redundant for a release, as I said, you can easily solve this problem by setting ban time to x years or not IP ban at all. Check with @Groruk

@koteq

This comment has been minimized.

Copy link
Contributor

koteq commented Sep 20, 2017

you can easily solve this problem by setting ban time

I don't like the idea of giving amnesty to hackers.

not IP ban at all

All the bans are done by SteamID but SB track IP even in that case.

@rumblefrog

This comment has been minimized.

Copy link
Member

rumblefrog commented Sep 21, 2017

Sleuth tracks IP only if the ban is still active, and I'm not sure why you wouldn't use the x years, you basically give them amnesty by expiring old bans.

@Alicebnd

This comment has been minimized.

Copy link

Alicebnd commented Sep 21, 2017

kinda redundant for a release, as I said, you can easily solve this problem by setting ban time to x years or not IP ban at all. Check with @Groruk

Ban players by steamid and ip have one fixed parameter - steamid and one dinamic parameter - ip (if banned player have dinamic ip).
In due course under the ban on this ip can get an honest player.
Therefore, sbpp_sleuth must be able to ignore the banned ip depending on the time.
The more time passes since the ban, the more likely join to server a good player with a banned ip.

@Alicebnd

This comment has been minimized.

Copy link

Alicebnd commented Sep 21, 2017

I have a history of bans from 2013.
Do you think how many good players are banned based on the banned dynamic ip's I have during five years?
I do not want to give amnesty to cheaters based on a fixed steamid.
It is necessary to give an amnesty only on the prescription of a ban on a variable ip, which eventually becomes erroneous.
Make edits you need to include in the release.

@rumblefrog

This comment has been minimized.

Copy link
Member

rumblefrog commented Sep 30, 2017

@Groruk

Here's a quick version I made implementing that. However, it's not tested, you're warned: https://gist.github.com/RumbleFrog/d893be81dd33808bfaa6934c3dbd8c63
It contains two additional ConVars

sm_sleuth_excludeold | 0 - Inactivated, 1 - Allow old bans to be excluded from ban check
sm_sleuth_excludetime | Amount of time in seconds to allow old bans to be excluded from ban check

LMK if this works.

@Alicebnd

This comment has been minimized.

Copy link

Alicebnd commented Sep 30, 2017

Its work for me.

@rumblefrog rumblefrog referenced this issue Sep 30, 2017

Merged

Plugin: Exclude Old Bans #356

3 of 7 tasks complete
@rumblefrog

This comment has been minimized.

Copy link
Member

rumblefrog commented Sep 30, 2017

Created a pull #356, If OP could test it, that'd be great.

@Groruk Groruk closed this in #356 Oct 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment