Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Issues with "servers" page/tab in latest SourceQuery update #368
First thing when you load the page of the servers tab and you click the server to view it's status, the time of everyone is "broken" (it's just formatted by seconds and it looks really dumb that way). Normally, it'll look something like this in this format: x hr, x min, x sec. After this update: it's formatted by how many seconds the client has been on for, which just looks really dumb. Also, when you right click on a person's name, it doesn't target the specific person that you clicked on, it targets the very last person on the list (unknown whether this is caused by the SourceQuery update).
Also, when you click the server refresh button, the dialog "Refreshing the ServerData" never disappears. It used to disappear on it's own. The player list also seems to be categorized through most play time rather than the score, as the old query method used to categorize people like that. Just a few nit-picky issues, nothing major.
The layout for the servers page should correctly display the time as formatted above (x hr, x min, x sec). The dropdown list for a server listed on the servers page should also be targeting the correct people you right click on. When you click the "Refresh" button, the dialog should pop-up and then promptly disappear, and the players should be categorized from the highest to the lowest score.
The layout for the servers page incorrectly displays the total time that each player has been on for (ex: a bunch numbers, such as 12220). If you also want to kick a person from a server or view their profile from the dropdown list by right clicking their names, it targets the very last person on the list by default despite you clicking on a completely different person. The "Refreshing the ServerDialog" button never disappears after you click the "Refresh" button, and the players are categorized from longest time on the server to shortest time on the server.
Steps to Reproduce (for bugs)
For time format bug:
For incorrect targetting on the server list:
For the refresh server dialog never disappearing:
For time bug (it puts it in a sort of readable format):
OR (this puts the format back to it's original working state, and in my opinion, it looks way better this way):
Categorize players with most score rather than play time:
I don't have a fix for the improper targeting, if I did then I would've pushed an edit already and deleted this since I fixed 3/4th's of the problem already.
Here's a gyazo in case you can't see the gif: https://i.gyazo.com/aaaa93ba2647bbeb9bca08005ae3b8da.mp4 / https://gyazo.com/aaaa93ba2647bbeb9bca08005ae3b8da