New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceComm forward fixes #330

Merged
merged 1 commit into from Jul 23, 2017

Conversation

Projects
None yet
2 participants
@SM91337
Copy link
Contributor

SM91337 commented Jul 21, 2017

Description

The DataPack contains the client index rather than userid, therefore in the callback the conversion to index is making it invalid, I have fixed this by setting the userid inside the DataPack.

I have also removed one of the DataPacks as there is no reason to use 2 in this case, 1 will sufficiently hold all of the data.

Motivation and Context

I found this bug when I was trying to use Discord/Slack API to send mutes through to my Discord server.

I have Fixed Admin and Target being invalid inside SourceComms forward.
And I have removed an uneeded DataPack from SourceComms forward, it now uses one instead.

How Has This Been Tested?

It has been tested on a Windows server and I have confirmed that everything is working as normal inside the forward.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [YES] My code follows the code style of this project.
  • [NO] My change requires a change to the documentation.
  • [N/A] I have updated the documentation accordingly.
  • [YES] I have read the CONTRIBUTING document.
Fixed Admin and Target being invalid inside SourceComms forward.
Removed uneeded DataPack from SourceComms forward, (Use one instead)

@Groruk Groruk merged commit d5a816d into sbpp:v1.x Jul 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SM91337 SM91337 referenced this pull request Jul 23, 2017

Closed

Fixed bug when admin and target in forward always be -1 #331

3 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment