New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 1000 Members Limit #337

Merged
merged 2 commits into from Aug 8, 2017

Conversation

Projects
None yet
2 participants
@rumblefrog
Copy link
Member

rumblefrog commented Aug 8, 2017

Description

Before, it's only possible to ban up to 1000 members of a group; now you can ban all of them, assuming Steam doesn't rate limit you. I modify the fetching process to remove an unnecessary file_put_contents request and added a loop that self-call if there's a next link indicated.

Addresses the 1000 members limit mentioned in #299

Motivation and Context

I came across a large cheater group (about 12k members), and I was in the process of banning them all until I found out that members list is paginated to 1000 per page. It addresses an issue mentioned in #299

How Has This Been Tested?

After I had made the code change, I re-attempted on banning the cheater group on PHP 7.1 with MariaDB 10.2 environment, while it took a while, it finished in the end with no error.

Although, note, if you're banning a large group, you may exceed Steam API's rate limit.

Screenshots (if appropriate):

https://i.imgur.com/QR6bJLf.png

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
RumbleFrog
@rumblefrog

This comment has been minimized.

Copy link
Member

rumblefrog commented Aug 8, 2017

If this works, I'll go ahead and edit the version file before merge

@Groruk Groruk merged commit ad01e60 into sbpp:v1.x Aug 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment