New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session mutes/gags #384

Merged
merged 1 commit into from Jan 10, 2018

Conversation

Projects
None yet
4 participants
@InvexByte
Copy link
Contributor

InvexByte commented Jan 5, 2018

Fixes session mutes/gags.

Description

See issue #309 for full details.

Note With this fix, session mutes/gags are not reapplied when a client disconnects.
However, they will still appear as ongoing in the database until the 120 minute mark hits.
Not a huge/major issue but to improve things, a UnmuteSessions function could send queries to mark all sessions as expired on reconnect. I thought it would be better to apply this fix first though.

Motivation and Context

Fixes session mutes/gags which currently act as 120 minute mutes.

How Has This Been Tested?

Tested with CSGO only with no mute, session mutes/gags, timed mutes/gags and perm mutes/gags.
I am unable to test other games.
Using latest git commit a80f9063e23e5f54f60e4e5db3f2560845ee740d for testing.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
Fix session mutes (Fixes #309)
See issue #309 for more details.

@InvexByte InvexByte changed the title Fix session mutes/gags (Fixes #309) Fix session mutes/gags Jan 5, 2018

@good-live

This comment has been minimized.

Copy link

good-live commented Jan 5, 2018

Any reason to write them into the DB in the first place?

@InvexByte

This comment has been minimized.

Copy link
Contributor

InvexByte commented Jan 5, 2018

Any reason to write them into the DB in the first place?

Why not? You'd perhaps want to log/record the mute in the DB even though its only a session mute.
There are plugins that already do this, no need to break them.

@rumblefrog

This comment has been minimized.

Copy link
Member

rumblefrog commented Jan 9, 2018

👌

@Groruk Groruk merged commit 4b145e0 into sbpp:v1.x Jan 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment