New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrated comms in checker plugin #398

Merged
merged 6 commits into from Feb 20, 2018

Conversation

Projects
None yet
6 participants
@DataWorm
Copy link

DataWorm commented Feb 16, 2018

As it was already mentioned in #188 this merge request adds support for comms to the checker plugin. So it does add the command sm_listcomms and also shows the amount of comms (if any) when a player joins. Code was successfully tested on our servers, all features seems to work just fine as expected.

@rumblefrog

This comment has been minimized.

Copy link
Member

rumblefrog commented Feb 17, 2018

Good job on bringing up forgotten issues.

@Sarabveer Sarabveer force-pushed the sbpp:v1.x branch 9 times, most recently from af17f86 to c4f18a7 Feb 19, 2018

@sneak-it

This comment has been minimized.

Copy link
Contributor

sneak-it commented Feb 19, 2018

This is awesome, thank you. Tested and working well across multiple servers, completely error-free. Incredibly helpful!

@Sarabveer

This comment has been minimized.

Copy link
Member

Sarabveer commented Feb 19, 2018

We don't really need backwards compatibility for this command.

@Sarabveer Sarabveer requested a review from Groruk Feb 19, 2018

@Groruk

Groruk approved these changes Feb 20, 2018

@Groruk Groruk merged commit d3ad62c into sbpp:v1.x Feb 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SkippYSB

This comment has been minimized.

Copy link

SkippYSB commented Feb 28, 2018

Good job! Great feature.
I have a problem though after i updated the sourcebans plugins with this new versions. On several game servers when administrators ban via menu the menu just disappears without any action, nothing in error logs either. Is there any context? Still works via commands in-game. This problem occurs on both CS:S/CS:GO. SM 1.8

@DataWorm

This comment has been minimized.

Copy link

DataWorm commented Feb 28, 2018

I don't think it is related to this ticket cause we only made changes on the checker plugin that doesn't contain code for ban menu nor does it create any bans. Anyway maybe you can tell the exact version you are using now and especially the version you used before if you still know that. That could help to identify the commits in which plugins got modified.

@SkippYSB

This comment has been minimized.

Copy link

SkippYSB commented Feb 28, 2018

Okay, thank you for a quick reply.
The old version i used was the first commit from 1.6.2, now i use the commit where you updated the checker. When i updated i just downloaded the SourceBans++ 1.6.3 - PRE.

Edit:
Shall i try go back to 1.6.2 without changing checker?

@DataWorm

This comment has been minimized.

Copy link

DataWorm commented Feb 28, 2018

Guess that might be a good test. Checked the history and most likely that commit might be related to your issue:
8518f31#diff-de25bbf1235c858d4088ab16c0f45aed

@SkippYSB

This comment has been minimized.

Copy link

SkippYSB commented Feb 28, 2018

Test = success. The problem is now solved. Yes probably the reason, thank you for your time and help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment