New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated smarty to 2.6.31 #399

Merged
merged 1 commit into from Mar 10, 2018

Conversation

Projects
None yet
3 participants
@keigel2001
Copy link
Contributor

keigel2001 commented Feb 18, 2018

This merge adds support for PHP 7.2.
It removes some deprecated messages, which were popping up, when using sourcebans-pp with PHP 7.2.

https://github.com/smarty-php/smarty/tree/Smarty2

@rumblefrog

This comment has been minimized.

Copy link
Member

rumblefrog commented Feb 18, 2018

I thought 9abea9f addressed the deprecation warnings

@keigel2001

This comment has been minimized.

Copy link
Contributor

keigel2001 commented Feb 18, 2018

No, not all.
Right when I openend my sourcebans++ I saw multiple "Deprecated: Function create_function()" warnings (includes/smarty/Smarty_Compiler.class.php on line 269).
And "each" is also deprecated.

He didn't update smarty to the newest version for some reason. Only in the newest version of smarty2 this is solved.

@Sarabveer Sarabveer force-pushed the sbpp:v1.x branch 9 times, most recently from af17f86 to c4f18a7 Feb 19, 2018

@rumblefrog rumblefrog requested a review from Groruk Feb 21, 2018

@Groruk Groruk merged commit 3a1d658 into sbpp:v1.x Mar 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment